Use engine commit hash when vendoring sources #172
Conversation
.github/workflows/Nightly.yml
Outdated
| @@ -58,6 +59,10 @@ jobs: | |||
| run: | | |||
| git push -u origin HEAD | |||
|
|
|||
| - name: Wait for push to complete | |||
| if: steps.vendor.outputs.vendor != '' && github.event_name != 'pull_request' | |||
| run: sleep 10 # Give GitHub a moment to process the push | |||
There was a problem hiding this comment.
Could you expand on why this sleep is necessary? Doesn't the push complete otherwise?
There was a problem hiding this comment.
M, I've just copied this bit from the latest ODBC workflow to keep JDBC in sync with it. I will re-check.
There was a problem hiding this comment.
As an update on this, I've got some input on GH workflows from Carlo, as a result the vendoring process in ODBC is being changed to import engine sources into a separate branch, create a PR on this branch and merge this PR automatically. In this variant the testing workflow is dispatched by triggering the pull_request event instead of a direct dispatch, so we do not need to wait manually until the push completes. I intend to bring the same workflow changes to JDBC once they are approved for ODBC, keeping this PR as a "draft" for now.
There was a problem hiding this comment.
Removed the timeout, now using push event instead that is expected only to be triggered by Github after the push is actually complete. Also removed the periodic trigger and submitted duckdb/duckdb/pull#17099 on the main DuckDB repo side to notify the JDBC vendoring process.
This PR brings duckdb/duckdb-odbc#102 changes to JDBC repo. The intention is to only run `Vendor.yml` workflow on a dispatch call from the mainline DuckDB after the CI runs are passed and extensions are built. On DuckDB engine side the workflow dispatch call is being added in duckdb/duckdb#17099 .
This change adds a dispatch call to `Vendor.yml` JDBC workflow the same way it is now done for ODBC repo. On JDBC side the workflow changes are being added in PR duckdb/duckdb-java#172 .
staticlibs
force-pushed
the
vendor_commit_id
branch
from
4ea8a30 to
83aca2a
Compare
|
@carlopi I wonder if you can look at this PR too along with the duckdb/duckdb#17099 . |
This change adds a dispatch call to `Vendor.yml` JDBC workflow the same way it is now done for ODBC repo. On JDBC side the workflow changes are being added in PR duckdb/duckdb-java#172 . ODBC call was initially added in #16730, see details in that PR.
|
Merging without review as a workflow-only change, and also to create the GH API entry point on |
This change adds a dispatch call to `Vendor.yml` JDBC workflow the same way it is now done for ODBC repo. On JDBC side the workflow changes are being added in PR duckdb/duckdb-java#172 .
This PR brings duckdb/duckdb-odbc#84 changes to JDBC repo.
Testing: no code changes, no new tests.